discord: Properly paginate through all users

[timschumi]

Fetching one page with 1000 users on it is not going to be enough for some servers.

[poVoq]

What is the effect of this right now before the patch?

[timschumi]

What is the effect of this right now before the patch?

The first (effectively random) 1000 Discord users can be pinged by name from other platforms, the others can not be pinged by name (because their user information is not in the list). By extension, every use of that list that assumes that the list is complete will be broken.

[soliton-]

The check is failing because of a formatting issue. You can run go fmt ./... yourself to fix it or apply this diff:

diff --git a/bridge/discord/discord.go b/bridge/discord/discord.go
index 29375c3..5c0c7b8 100644
--- a/bridge/discord/discord.go
+++ b/bridge/discord/discord.go
@@ -227,7 +227,7 @@ func (b *Bdiscord) Connect() error {
                                b.nickMemberMap[member.Nick] = member
                        }
                }
-               after = members[len(members) - 1].User.ID
+               after = members[len(members)-1].User.ID
        }
        
        b.c.AddHandler(b.messageCreate)

(With PR #196 merged you could see the diff in the CI logs.)

[poVoq]

Looks good now. Can you still add a changelog entry for it please?