Conversation
|
Thanks! Could you maybe add a link to the PR (markdown formatting)? Otherwise all good to go. |
|
Ah, thanks for being faster than me. |
|
No actually my bad, this change should go in the "BREAKING" section :) |
|
What exactly is breaking about this? You keep mentioning that... |
|
It's a bit ambiguous but I lean that it's not breaking, it just might be annoying. It's not going to stop someone's bridge working, and if they don't like it hopefully they'll find the note in the changelog. Now what this really needs is documentation. I'll add that too. |
kousu
force-pushed
the
discord-reply-changelog
branch
from
f97fa79 to
acd3998
Compare
kousu
force-pushed
the
discord-reply-changelog
branch
from
acd3998 to
894a1fc
Compare
I respectfully disagree. Unless that was an obvious bug to be fixed, any observable change in behavior is a breaking change. I would not have even realized if you had not mentioned that you need to update your config to keep the same behavior: that's close-enough to the definition of a breaking change XD Anyway, my understanding is that we'll revamp the reply system before release and may update the changelog accordingly then, so no worries right now. |
3 participants
Re: #124