This repository was archived by the owner on Feb 16, 2019. It is now read-only.
Updating from ETE2 to ETE3#80
Open
JosephRyanPeterson wants to merge 3 commits intomattb112885:masterfrom
Open
Conversation
Owner
|
Joe, can you confirm whether the latest version of ETE3 still shows this problem? Best Matt |
Collaborator
Author
|
Hi Matt, #70 remains an issue with ETE3. I'm digging into it further. Joe |
Collaborator
Author
|
#70 should be resolved by my most recent commit to my branch. There appeared to be an off-by-one error when populating the columns of the node face. I checked for correctness only with one example though, so take it with a grain of salt. |
Collaborator
Author
|
Hi Matt, |
Owner
|
The concern I have with this is that people who have the vm distributed with the code won't be able to update ITEP without breaking it. I need to do some compatibility testing, can you hold off on merging for a bit? Matt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.