Implement current state of WebSocketAPI #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- as a precursor to allowing us to send messages.
Differentiate between json matrix errors, and generic http errors; return different error types for the two.
client-side "send" method
It results in less code duplication if we have the request handler methods return result & error objects instead of a complete response object
Conflicts: proxy/conn.go
Member
|
Can one of the admins verify this patch? |
|
Do you think this PR will merged someday? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the state described in this google-doc in this websockets-proxy as kind of reference implementation
I decided to create the pull-request to branch
rav/send_messagesinstead ofmasterto see the changes I made.