Skip to content

Conversation

@MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Apr 26, 2023

Preload fonts and images

Part of #132

TODO

  • Make sure we don't duplicate load the fonts because the path comes to us as Inter-Regular.woff2?v=3.13 with a query parameter which counts as a different URL than what we preloaded, see Preload fonts and images #187 (comment)

@MadLittleMods MadLittleMods added the A-performance What is slow, what made it faster and more efficient? label Apr 26, 2023
@MadLittleMods MadLittleMods added the T-Enhancement New feature or request label Apr 26, 2023
MadLittleMods added a commit that referenced this pull request Apr 26, 2023
Of note:

 - Adds date headers, element-hq/hydrogen-web#938
 - Add "Copy matrix.to permalink" message action, element-hq/hydrogen-web#921
 - Removes `?v=3.13` query parameters from Inter font references in CSS, element-hq/hydrogen-web#961
    - This is what we need to solve #187 (comment)
@MadLittleMods MadLittleMods marked this pull request as ready for review April 26, 2023 21:26
@MadLittleMods MadLittleMods merged commit e20a67d into main Apr 26, 2023
@MadLittleMods MadLittleMods deleted the madlittlemods/preload-fonts-and-images branch May 2, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-performance What is slow, what made it faster and more efficient? T-Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants