Skip to content

Typos and clarifications#2318

Open
HarHarLinks wants to merge 10 commits intomatrix-org:mainfrom
HarHarLinks:HarHarLinks/typos-etc
Open

Typos and clarifications#2318
HarHarLinks wants to merge 10 commits intomatrix-org:mainfrom
HarHarLinks:HarHarLinks/typos-etc

Conversation

@HarHarLinks
Copy link
Contributor

@HarHarLinks HarHarLinks commented Feb 20, 2026 •
edited by github-actions bot
Loading

Pull Request Checklist

Preview: https://pr2318--matrix-spec-previews.netlify.app

HarHarLinks
HarHarLinks commented Feb 20, 2026
View reviewed changes
@HarHarLinks HarHarLinks force-pushed the HarHarLinks/typos-etc branch from 86d3b58 to 70ff313 Compare February 20, 2026 13:02
HarHarLinks
HarHarLinks commented Feb 20, 2026
View reviewed changes
data/event-schemas/schema/core-event-schema/event.yaml Outdated
Comment on lines 10 to 11
description: The type of event. This SHOULD be namespaced similar to Java package
naming conventions e.g. 'com.example.subdomain.event.type'
naming conventions e.g. `com.example.subdomain.event.type`
Copy link
Contributor Author

@HarHarLinks HarHarLinks Feb 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arguably this whole explanation is in the wrong place here since how event types work is defined elsewhere. Would you agree to me changing the description respectively?

Copy link
Member

@richvdh richvdh Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you agree to me changing the description respectively?

sure, this isn't very elegant as things stand.

Copy link
Contributor Author

@HarHarLinks HarHarLinks Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in a34a6f8

@HarHarLinks
fix some typos, formatting and wording
9ad39c3 
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
@HarHarLinks
fix inconsistent colon in tables
3cd366b 
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
@HarHarLinks
format as code
55f1c15 
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
@HarHarLinks HarHarLinks force-pushed the HarHarLinks/typos-etc branch from 70ff313 to 55f1c15 Compare February 20, 2026 13:06
HarHarLinks
HarHarLinks commented Feb 20, 2026
View reviewed changes
@HarHarLinks
fix the name of the Foundation
634acbc 
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
@HarHarLinks
add changelog
c12fbe4 
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
@HarHarLinks HarHarLinks marked this pull request as ready for review February 20, 2026 14:02
@HarHarLinks HarHarLinks requested a review from a team as a code owner February 20, 2026 14:02
@HarHarLinks
add comma
afa06ad 
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
richvdh
richvdh approved these changes Feb 24, 2026
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for your attention to detail.

data/event-schemas/schema/core-event-schema/event.yaml Outdated
Comment on lines 10 to 11
description: The type of event. This SHOULD be namespaced similar to Java package
naming conventions e.g. 'com.example.subdomain.event.type'
naming conventions e.g. `com.example.subdomain.event.type`
Copy link
Member

@richvdh richvdh Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you agree to me changing the description respectively?

sure, this isn't very elegant as things stand.

changelogs/internal/newsfragments/2318.clarification Outdated
@@ -0,0 +1 @@
Fix typos, formatting, wording. Contributed by @HarHarLinks.
Copy link
Member

@richvdh richvdh Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably no need for a separate internal changelog here

Copy link
Contributor Author

@HarHarLinks HarHarLinks Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this because I technically modified the footer in config/_default/hugo.toml 🤷

@HarHarLinks
Copy link
Contributor Author

HarHarLinks commented Feb 24, 2026

Thanks! I'll give #2318 (comment) a go tomorrow or so

@HarHarLinks
format some literals and keywords
15a5cff 
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
@HarHarLinks
reference event type spec instead of duplicating
a34a6f8 
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
@HarHarLinks HarHarLinks force-pushed the HarHarLinks/typos-etc branch from 1effa3b to a34a6f8 Compare February 25, 2026 04:28
@HarHarLinks
update changelogs
ddc6114 
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
@HarHarLinks
fix up link
fa26eaa 
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richvdh richvdh richvdh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HarHarLinks @richvdh