Spec for MSC4335: M_USER_LIMIT_EXCEEDED error code#2315
Spec for MSC4335: M_USER_LIMIT_EXCEEDED error code#2315hughns wants to merge 1 commit intomatrix-org:mainfrom
Conversation
| only read state (e.g.: [`/sync`](#get_matrixclientv3sync), | ||
| [`/user/{userId}/account_data/{type}`](#get_matrixclientv3useruseridaccount_datatype), etc). | ||
|
|
||
| `M_USER_LIMIT_EXCEEDED` |
There was a problem hiding this comment.
Is this too long for this section of the doc?
I personally think the details and example are helpful, but they make the others look sparse!
I could add an extra section like M_LIMIT_EXCEEDED has?
There was a problem hiding this comment.
I think the main problem is that it's easy to miss the fact that the whole thing, including the example response, is part of M_USER_LIMIT_EXCEEDED.
I think we could solve this by either 1. reformatting the section to make it clearer (one option would be to use <dl> items, as in the Push notifications section), or 2. moving the body of the definition out to another section, as you suggest.
I have no strong opinion on which is preferable.
richvdh
left a comment
There was a problem hiding this comment.
LGTM otherwise. Thanks for writing this up.
| only read state (e.g.: [`/sync`](#get_matrixclientv3sync), | ||
| [`/user/{userId}/account_data/{type}`](#get_matrixclientv3useruseridaccount_datatype), etc). | ||
|
|
||
| `M_USER_LIMIT_EXCEEDED` |
There was a problem hiding this comment.
I think the main problem is that it's easy to miss the fact that the whole thing, including the example response, is part of M_USER_LIMIT_EXCEEDED.
I think we could solve this by either 1. reformatting the section to make it clearer (one option would be to use <dl> items, as in the Push notifications section), or 2. moving the body of the definition out to another section, as you suggest.
I have no strong opinion on which is preferable.
For MSC4335.
Pull Request Checklist
Signed-off-by: Hugh Nimmo-Smith hughns@element.io
Preview: https://pr2315--matrix-spec-previews.netlify.app