Skip to content

Spec for MSC4335: M_USER_LIMIT_EXCEEDED error code#2315

Open
hughns wants to merge 1 commit intomatrix-org:mainfrom
hughns:msc4335
Open

Spec for MSC4335: M_USER_LIMIT_EXCEEDED error code#2315
hughns wants to merge 1 commit intomatrix-org:mainfrom
hughns:msc4335

Conversation

@hughns
Copy link
Member

@hughns hughns commented Feb 20, 2026

For MSC4335.

Pull Request Checklist

Signed-off-by: Hugh Nimmo-Smith hughns@element.io

Preview: https://pr2315--matrix-spec-previews.netlify.app

only read state (e.g.: [`/sync`](#get_matrixclientv3sync),
[`/user/{userId}/account_data/{type}`](#get_matrixclientv3useruseridaccount_datatype), etc).

`M_USER_LIMIT_EXCEEDED`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this too long for this section of the doc?

I personally think the details and example are helpful, but they make the others look sparse!

I could add an extra section like M_LIMIT_EXCEEDED has?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main problem is that it's easy to miss the fact that the whole thing, including the example response, is part of M_USER_LIMIT_EXCEEDED.

I think we could solve this by either 1. reformatting the section to make it clearer (one option would be to use <dl> items, as in the Push notifications section), or 2. moving the body of the definition out to another section, as you suggest.

I have no strong opinion on which is preferable.

@hughns hughns marked this pull request as ready for review February 20, 2026 09:46
@hughns hughns requested a review from a team as a code owner February 20, 2026 09:46
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thanks for writing this up.

only read state (e.g.: [`/sync`](#get_matrixclientv3sync),
[`/user/{userId}/account_data/{type}`](#get_matrixclientv3useruseridaccount_datatype), etc).

`M_USER_LIMIT_EXCEEDED`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main problem is that it's easy to miss the fact that the whole thing, including the example response, is part of M_USER_LIMIT_EXCEEDED.

I think we could solve this by either 1. reformatting the section to make it clearer (one option would be to use <dl> items, as in the Push notifications section), or 2. moving the body of the definition out to another section, as you suggest.

I have no strong opinion on which is preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants