Implemented XEP-0106 JID Escaping Transformations for Matrix room IDs

[rakaar]

Implemented XEP-0106 Escaping transformations as mentioned in #83 as per this document in the file src/MatrixRoomHandler.ts. This is done using a function by name XEP0106_APPLY_ESCAPING_TRANSFORMATIONS at the top of the file after imports.

To ensure, nothing is broken, I have run the command npm run test, which resulted in all tests passed.

[Half-Shot]

This looks good, thank you! One thing to mention is that it would be nice to see some test cases written up as unit tests. It should be easy because the function is static and hasno dependencies.

[rakaar]

@Half-Shot
Made the changes as you requested.

it would be nice to see some test cases written up as unit tests. It should be easy because the function is static and has no dependencies

Do you want me to write unit tests?

[Half-Shot]

Yes please :)

[rakaar]

@Half-Shot
I have tried writing tests related to JID escaping in a seperate file test/test_matrixroomhandler.ts,
But when I run them, I face this error: SyntaxError: Octal escape sequences are not allowed in strict mode.
I have also included /* tslint:disable */ and also // tslint:disable: no-any at the beginning of the file. But the error persists.
What can I do to run the tests smoothly?
Here is a screenshot of the error I am getting

[Half-Shot]

Would you mind commuting your changes anyway, so I can take a look.

[Half-Shot]

Just noticed, could you remove the package-lock.json file from your PR. We use yarn (which uses yarn.lock).

[rakaar]

@Half-Shot
I have squashed my commits into one.
The XEP0106_ESCAPING_TRANSFORMATIONS object contains the one, mentioned in #83 issue, and for test cases, I took the roomId reference here and examples mentioned in the document. I have run the test cases and all of them have passed, including the once I newly wrote.

[rakaar]

@Half-Shot
Is there anything else, that I am missing. If yes then please let me know. I would update the PR.

[Neustradamus]

@rakaar, @Half-Shot: Any news?