Fix bridging for recreated DM rooms#376
Merged
AndrewFerr merged 5 commits intodevelopfrom Apr 1, 2026
Merged
Conversation
Fix incoming messages in DM rooms created after having left an older DM room with the same XMPP user. Also make fixes to & improve typing of PgDatastore.
Don't block startup until all IM rooms are scanned for staleness. Instead, kick off a scan to be done asynchronously, and only block incoming IMs on a per-chat basis, until the scan on its associated Matrix room has finished. Also don't consider an IM room as stale if an attempt to look up membership state fails with anything other than a 403 or 404 response, as those are the only responses that definitively indicate something wrong with membership in the room.
jaywink
approved these changes
Apr 1, 2026
Member
jaywink
left a comment
jaywink
left a comment
There was a problem hiding this comment.
Elegant, last changes make things much more maintainable imho, and less prone to introducing new issues, thanks!
Member
Author
|
Thanks for the review; it really pushed this in the right direction! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incoming messages in DM rooms created after having left an older DM room with the same XMPP user.
Also make fixes to & improve typing of PgDatastore.
Replaces #373