This repository was archived by the owner on May 3, 2019. It is now read-only.
Add a clear settings prompt to application installs#109
Open
diegoribero wants to merge 1 commit intodevfrom
Open
Add a clear settings prompt to application installs#109diegoribero wants to merge 1 commit intodevfrom
diegoribero wants to merge 1 commit intodevfrom
Conversation
Contributor
|
@diegoribero this should only fire if an application has settings :) |
eighteyes
suggested changes
Nov 1, 2017
Contributor
eighteyes
left a comment
eighteyes
left a comment
There was a problem hiding this comment.
shouldn't fire if application has no settings. please output default settings in message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires a PR from matrix-firebase to be merged, once that PR is merged this one should follow