Changes from Unofficial Mator Smash Updated#252
Changes from Unofficial Mator Smash Updated#252chuckseven1 wants to merge 76 commits intomatortheeternal:masterfrom
Conversation
No longer needed with newer xEdit
Still treats it the same as SSE, but should detect it properly now.
|
Alright, I'll review this over the next few days. 👍 |
Should help to smash more plugins without reaching 253 master limit.
matortheeternal
left a comment
matortheeternal
left a comment
There was a problem hiding this comment.
A few things that need to be fixed.
|
Also it seems like string file loading may be broken based on the comments on Nexus Mods. You should look into that. |
Yes I saw the comments on nexus. I have started looking into it. Not sure why it only seems to affect some localized strings, but I am clearly doing something wrong with them. |
I think something in how localization is handled got changed from xEdit 3.x to 4.x, look into how they're doing localization shenanigans in the xEdit codebase and see if you can update things here appropriately. If you can't see an issue you might have to get someone to send you their strings file(s). It could be a lot of different things, might be difficult to debug. You're certain it's only happening with some localized strings and not all? |
I had a string result in that error one time I smashed, then after changing my LO the same record was still in my smashed patch but that time it had the right value... Yes I will look at xEdit to try to figure it out when I get the chance. |
OK, will merge and publish as soon as this is resolved. |
No need to translate them since we don't show them in the smash UI. This seems to resolve the "No strings file for lstring" error.
Now that masters get added dynamically, it made the tracker not useful.
Seems to fixed localized strings Must be configuring xEdit wrong if it is not loading them?
|
The localized strings issue is because the BSAs corresponding to plugins in the LO are not being loaded. I added code to load them myself and the strings all come out correct for me. I must still be configuring xEdit wrong? I imagine it supports loading the BSAs automagically for the plugins. |
It exists even if the array is not sorted. Fixes error from confusion when mods change EditorID of elements.
Need to figure out what I do wrong to make that happen. Especially seems to happen with USMP? This workaround is not perfect, but less broken than before...
Now the smashing thread does not get held up by logs. Mostly helps with speed when debugging is on, but seems slightly faster normally as well. TODO: Unify the tracker logs and the mte logs?
4 participants
Please tell me if any of these changes look insane. I made a few... educated guesses when changing from the xEdit 3 API to 4.