Added required aria-expanded attributes and fixed closing focus#210
Merged
Added required aria-expanded attributes and fixed closing focus#210
Conversation
swarty
approved these changes
Nov 3, 2025
plegner
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PL-128 CKLA: Add Aria Label on Reset Button
this pr adds the
aria-expandedattribute to the popup component. you can read more aboutaria-expandedon MDN.this pr also returns focus to the popup control when it's closed which is expected behavior for accessible menus, modals, and so on.