Open
Conversation
matheusvb3
force-pushed
the
compat
branch
2 times, most recently
from
b42ca10 to
b30475d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
/rct1,/rct2and/rct12to a/compatibilitydirectory/rct12to/sharedsince that makes more semantic senseFlagHoldersFwd.hwhich contains forwards declarations for all flag holders that are shared betweenRCT1.h,RCT2.handRCT12.hRight now it only contains
BannerFlagsandRideInvalidateFlagsbut will grow as more FlagHolder conversions happen.For reviewers: I'm unsure if I should actually include FlagHolder.hpp in FlagHoldersFwd.h or I should also forward declare the FlagHolder type in that file (like it was being done in RCT2.h) to avoid importing FlagHolder.hpp into RCT1.h, RCT2.h and RCT12.h as well?