Merged
Conversation
4 tasks
Contributor
|
As discussed in the meeting, now that rocq-prover/rocq#20707 is in 9.1, and since odd-order is essentially a leaf in the library dependency graph, let's drop support for Rocq < 9.1 and use the new feature to simplify the current overlay. |
Contributor
|
CI green both on math-comp/math-comp#1439 and here, let's merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
math-comp/math-comp#1439 puts the
finGroupTypestructure on top of the hierarchy inmonoid.v, which as usual breaksrewrite(rocq-prover/rocq#20707 should prevent this from happening in the future). There are also a few more notations ingroup_scopewhich conflict with others in other scopes (e.g._``__fromnat_scope).