Skip to content

Adapt to math-comp/math-comp#1395#68

Merged
proux01 merged 2 commits intomasterfrom
semi-poly
Apr 8, 2025
Merged

Adapt to math-comp/math-comp#1395#68
proux01 merged 2 commits intomasterfrom
semi-poly

Conversation

@pi8027
Copy link
Member

@pi8027 pi8027 commented Apr 6, 2025

@pi8027 pi8027 changed the title Adapt to math-comp/math-cmop#1395 Adapt to math-comp/math-comp#1395 Apr 6, 2025
@pi8027 pi8027 force-pushed the semi-poly branch 2 times, most recently from 4000dbd to 2c60cf5 Compare April 6, 2025 21:01
@pi8027 pi8027 requested a review from proux01 April 7, 2025 10:56
@pi8027 pi8027 force-pushed the semi-poly branch 2 times, most recently from 31592c9 to 61d1397 Compare April 7, 2025 15:22
@pi8027
Copy link
Member Author

pi8027 commented Apr 8, 2025

CI green

@proux01 proux01 merged commit ee5ef8e into master Apr 8, 2025
13 of 18 checks passed
@proux01 proux01 deleted the semi-poly branch April 8, 2025 09:16
@proux01
Copy link
Contributor

proux01 commented Apr 8, 2025

I just updated the comment in the hope we'll find it by greping 2.4.0 in the future (that's usually what I do when dropping Coq support in mathcomp, although I must admit it's less likely I'll ever do it here)

@pi8027
Copy link
Member Author

pi8027 commented Apr 8, 2025

I have the impression that odd-order can benefit from the stuff recently added to MathComp, e.g., the first commit of this PR. It would be great if we could take a look at the proofs and clean them up every few years. (Indeed, the problem is that no one has time to do this kind of low-priority and time-consuming task.)

@proux01
Copy link
Contributor

proux01 commented Apr 8, 2025

Considering odd-order is rather a leaf in the dependency tree (I'm not sure anyone really depend on it), I guess it would be fine to have it only compile with the last mathcomp. So as soon as 2.4.0 is out, feel free to drop support for any older mathcomp and take advantage of the recent stuffs to do any simplification here.
But yes, main constraint is lack of human resource I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants