Adapt to rocq-prover/rocq#21531 (stricter Type in Type)#573
Merged
proux01 merged 1 commit intomath-comp:masterfrom Feb 12, 2026
Merged
Adapt to rocq-prover/rocq#21531 (stricter Type in Type)#573proux01 merged 1 commit intomath-comp:masterfrom
proux01 merged 1 commit intomath-comp:masterfrom
Conversation
yannl35133
force-pushed
the
stricter-type-in-type
branch
from
0f0a56f to
9749e00
Compare
Contributor
Author
|
@CohenCyril can you take a look? The use of Type-in-Type that is removed looks dubious, but I don't understand the proofs so I can't fix it. |
Member
|
Oh indeed this is suspicious... |
|
Please merge now. |
Contributor
|
@yannl35133 FWIW, this seems backward compatible and should never have been a synchronous overlay (it should have been merged before the upstream PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to rocq-prover/rocq#21531
This fix is not subtle, there may be better ways to do this. As long as you stop relying on Type irrelevance, this will work