Merged
Conversation
CohenCyril
reviewed
Jul 27, 2020
| near=> c; move: k'Ok kOg; apply: filter_app2; near=> x => lek'c2k. | ||
| rewrite -(@ler_pmul2l _ c2%:num) // mulrA => /(le_trans lek'c2k) /le_trans; apply. | ||
| by rewrite ler_pmul //; near: c; apply: locally_pinfty_ge. | ||
| Unshelve. end_near. Grab Existential Variables. all: end_near. Qed. |
Member
There was a problem hiding this comment.
@affeldt-aist I wonder if this still compiles with Coq 8.10 and 8.11
Member
Author
There was a problem hiding this comment.
It went through. But we'd better get rid of it.
Member
There was a problem hiding this comment.
Sorry, I meant: does removing this still make Coq 8.10 pass?
Member
Author
There was a problem hiding this comment.
CohenCyril
reviewed
Jul 27, 2020
opam
Outdated
| ] | ||
| depends: [ | ||
| "coq" { ((>= "8.7" & < "8.12~") | = "dev") } | ||
| "coq" { ((>= "8.7" & < "8.13~") | = "dev") } |
Member
There was a problem hiding this comment.
AFAIK Coq < 8.10 is not supported anymore
affeldt-aist
force-pushed
the
compatibility_coq_8_12
branch
from
f22b44d to
64f2f5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix a compatibility problem with Coq 8.12 observed by Karl.