Merged
Conversation
6 tasks
affeldt-aist
force-pushed
the
contributing_guide
branch
from
9eaa601 to
df6a140
Compare
CohenCyril
reviewed
Aug 7, 2020
CohenCyril
reviewed
Aug 7, 2020
CohenCyril
reviewed
Aug 7, 2020
CohenCyril
reviewed
Aug 7, 2020
CohenCyril
reviewed
Aug 7, 2020
CohenCyril
reviewed
Aug 7, 2020
CohenCyril
reviewed
Aug 7, 2020
CohenCyril
reviewed
Aug 7, 2020
CohenCyril
approved these changes
Aug 7, 2020
Member
CohenCyril
left a comment
CohenCyril
left a comment
There was a problem hiding this comment.
I think this can be merged as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to explain good practices that are specific to mathcomp-analysis. Still embryonic.