generalization ball_open#1894
Merged
affeldt-aist merged 2 commits intomath-comp:masterfrom Mar 11, 2026
Merged
Conversation
Co-authored-by: Marie Kerjean <marie.kerjean@cnrs.fr>
affeldt-aist
force-pushed
the
normed_module_20260311
branch
from
26b1ad9 to
c3eefe6
Compare
affeldt-aist
added
the
enhancement ✨
mkerjean
approved these changes
Mar 11, 2026
Collaborator
mkerjean
left a comment
mkerjean
left a comment
There was a problem hiding this comment.
Simplifying the proofs, great !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We have observed than
ball_opencan be generalized and this PR implements just that change,allowing for a factorization in tvs proofs.
Checklist
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers