Conversation
t6s
left a comment
There was a problem hiding this comment.
The changes look good.
I have realized that my original intention (in infotheo) was pointless,
but this generalization here should be valuable on its own.
|
My opinion (please ignore it): |
This is a bit particular. This is because
It is true that at some point it was used in the way we would use @t6s What do you think? |
|
I feel rather fine to use (abuse) unstable in some other development (like infotheo), but it might be indeed bad to motivate an update to unstable by such an external issue. Apart from that moral issue, this PR itself is just a simple improvement and would be worth being merged. As for onem itself, I am happy too if it can be removed at all. The notation |
|
Thanks for the explanations! I don't have anything against a |
|
Yeah, RIP |
Co-authored-by: Takafumi Saikawa <tscompor@gmail.com>
d73f9a1 to
a19fcf7
Compare
Co-authored-by: Takafumi Saikawa <tscompor@gmail.com>
Motivation for this change
this generalization is needed by @t6s in another development
Checklist
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers