Skip to content

fixes #1463#1663

Merged
affeldt-aist merged 1 commit intomath-comp:masterfrom
affeldt-aist:fixes_1463_20250701
Jul 1, 2025
Merged

fixes #1463#1663
affeldt-aist merged 1 commit intomath-comp:masterfrom
affeldt-aist:fixes_1463_20250701

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Jul 1, 2025

Motivation for this change

fixes #1463

@IshiguroYoshihiro Can you confirm that it addresses your issue?
(after 2, 3 releases we will remove the _tmp suffixes)

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.12.0 milestone Jul 1, 2025
@affeldt-aist affeldt-aist added the "bug" 🐛 This issue (resp. PR) describes (resp. fixes) a "bug" label Jul 1, 2025
@IshiguroYoshihiro
Copy link
Contributor

It looks good for me.
Thank you.

@affeldt-aist
Copy link
Member Author

@proux01 is that ok to use the _tmp for a two stage deprecation?

@affeldt-aist affeldt-aist force-pushed the fixes_1463_20250701 branch from 0e27fe4 to d22e2dc Compare July 1, 2025 09:24
@affeldt-aist affeldt-aist requested a review from proux01 July 1, 2025 09:24
@proux01
Copy link
Collaborator

proux01 commented Jul 1, 2025

Yes, that's what we usually do.

@affeldt-aist affeldt-aist merged commit 86963af into math-comp:master Jul 1, 2025
34 checks passed
@affeldt-aist affeldt-aist deleted the fixes_1463_20250701 branch July 1, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

"bug" 🐛 This issue (resp. PR) describes (resp. fixes) a "bug"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

name: cvgeMl -> cvgeMr?

3 participants