Merged
Conversation
Member
Author
|
This PR is just for an easy fix and gets rid of a couple of warnings, will merge if CI is green enough. |
|
|
||
| End matrix_Topology. | ||
|
|
||
| Section matrix_PointedTopology. |
Member
There was a problem hiding this comment.
I'm assuming this does not need an entry in the changelog
Member
Author
There was a problem hiding this comment.
Yes because it was duplicating code that is anyway inaccessible for the user since it is code automatically generated by HB.
IshiguroYoshihiro
pushed a commit
to IshiguroYoshihiro/analysis
that referenced
this pull request
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes #1603
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers