Skip to content

Accelerated Analysis#1441

Merged
affeldt-aist merged 1 commit intomath-comp:masterfrom
Tragicus:perf
Dec 21, 2024
Merged

Accelerated Analysis#1441
affeldt-aist merged 1 commit intomath-comp:masterfrom
Tragicus:perf

Conversation

@Tragicus
Copy link
Collaborator

Motivation for this change

There are a few lines that take a long time to compile (up to 12s). This PR takes every line that takes above 1s to compile and that is not an import or an HB command and rewrites it in less than a second (when I could). This saves overall 7% of the compilation time (with most of the time save (-29%) in lebesgue_integral.v).

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@Tragicus
Copy link
Collaborator Author

Tragicus commented Dec 19, 2024

@CohenCyril mentioned that integral should probably be locked. I tried something but did not observe any time save on the slow lines a was looking at (the set of which is obviously not empty), so I gave up.
EDIT: I think I am misremembering and it is funpos and funneg that I was supposed to lock, otherwise the unification of \int[mu]_(x in D) f1^\+ x with \int[mu]_(x in D) f1^\- x obviously goes under the lock.

@Tragicus
Copy link
Collaborator Author

I am not convinced that we want all the changes, I can add the time saved be each change if this helps the decision making.

@Tragicus Tragicus changed the title perf patch lebesgue_integral.v Analyse faster Dec 19, 2024
@Tragicus
Copy link
Collaborator Author

Fun fact: ~16% of the total compilation time is spent on HB commands and ~27% is spent importing things.

@Tragicus Tragicus changed the title Analyse faster Accelerated Analysis Dec 20, 2024
@affeldt-aist affeldt-aist self-requested a review December 20, 2024 13:34
@affeldt-aist affeldt-aist added this to the 1.9.0 milestone Dec 20, 2024
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Dec 20, 2024
Copy link
Contributor

@zstone1 zstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! Happy to see these improvements

@affeldt-aist affeldt-aist merged commit a658a6b into math-comp:master Dec 21, 2024
@Tragicus Tragicus deleted the perf branch January 8, 2025 14:04
ndslusarz pushed a commit to ndslusarz/analysis that referenced this pull request Feb 12, 2025
@Tragicus Tragicus mentioned this pull request Mar 31, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants