generalize the return type of RVs#1420
Merged
affeldt-aist merged 4 commits intomath-comp:masterfrom Dec 3, 2024
Merged
Conversation
affeldt-aist
added
the
enhancement ✨
t6s
approved these changes
Dec 3, 2024
Member
t6s
left a comment
t6s
left a comment
There was a problem hiding this comment.
LGTM.
Only thing I noticed is expectationMl could be expectationZ.
Co-authored-by: Alessandro Bruni <alessandro.bruni@gmail.com>
affeldt-aist
force-pushed
the
RV_20241203
branch
from
3243721 to
e592efa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is an uncontroversial part of the PR on sampling: it just generalizes the type of random variables. This has been made possible by the recent generalization of measurable functions defined as a type in
lebesgue_measure.v.Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers