Merged
Conversation
bf79201 to
1faad8f
Compare
1faad8f to
6d403c9
Compare
Member
Author
|
CI errors are unrelated, since master is already red, I think this can be merged. |
proux01
approved these changes
Dec 3, 2024
6d403c9 to
96a7885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes #1408
fixes #1417
fixes #1390
fixes #1389
Checklist
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersReference: How to document
Reminder to reviewers