Merged
Conversation
affeldt-aist
added
the
enhancement ✨
affeldt-aist
force-pushed
the
pi_irrational
branch
from
2053c7f to
fe8a6a5
Compare
zstone1
reviewed
Oct 31, 2024
Contributor
zstone1
left a comment
zstone1
left a comment
There was a problem hiding this comment.
Overall a nice milestone that we can do this in ~600 lines now. Sadly at least 50% of that seems to be about measurable/differentiable/integrable stuff that ought to be automated. But it's a nice application nonetheless.
Moving some of the files around as you mentioned in your comments is probably good. Especially the polynomial stuff will be nice to have independently. And the filename thing should be an easy fix. Otherwise I don't see any blockers
affeldt-aist
force-pushed
the
pi_irrational
branch
from
fe8a6a5 to
c8a3ee6
Compare
zstone1
approved these changes
Dec 19, 2024
Contributor
zstone1
left a comment
zstone1
left a comment
There was a problem hiding this comment.
Looks pretty good at this point. One question about an extra lemma, but I'm not seeing any blockers at this point
affeldt-aist
force-pushed
the
pi_irrational
branch
from
ae96d35 to
ce1e344
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
@LaurenceRideau
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers