You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR also shuffles the contents of the file lebesgue_measure.v
so that lemmas that do not depend on Lebesgue's measure appear
before it (the Egorov theorem in particular).
Checklist
- [ ] added corresponding entries in CHANGELOG_UNRELEASED.md
The reason will be displayed to describe this comment to others. Learn more.
Docs changes are good. Putting the code in a less-dependent order certainly can't hurt. Although given the shape of the diff it's hard to tell if it helps. I'll make my usual plea for splitting these big files.
I also think that lebesgue_measure.v should be split, it not well named anyway, its first part is about real-valued measurable functions, I didn't go as far as appending its first part to measure.v because the latter is already very long, a new file like measurable_realfun.v might be better, what about recording the splitting idea as a issue for later (unless you think it is a better idea to do it now)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documentation 📝This issue/PR is about documentation of the library / repository
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes #1313
This PR also shuffles the contents of the file
lebesgue_measure.vso that lemmas that do not depend on Lebesgue's measure appear
before it (the Egorov theorem in particular).
Checklist
- [ ] added corresponding entries inCHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers