Skip to content

fixes #1313 and moves Egorov#1314

Merged
affeldt-aist merged 2 commits intomath-comp:masterfrom
affeldt-aist:fixes_1313
Sep 8, 2024
Merged

fixes #1313 and moves Egorov#1314
affeldt-aist merged 2 commits intomath-comp:masterfrom
affeldt-aist:fixes_1313

Conversation

@affeldt-aist
Copy link
Member

Motivation for this change

fixes #1313

This PR also shuffles the contents of the file lebesgue_measure.v
so that lemmas that do not depend on Lebesgue's measure appear
before it (the Egorov theorem in particular).

Checklist

- [ ] added corresponding entries in CHANGELOG_UNRELEASED.md

  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist affeldt-aist added the documentation 📝 This issue/PR is about documentation of the library / repository label Sep 8, 2024
@affeldt-aist affeldt-aist added this to the 1.4.0 milestone Sep 8, 2024
@affeldt-aist affeldt-aist requested a review from zstone1 September 8, 2024 12:29
Copy link
Contributor

@zstone1 zstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes are good. Putting the code in a less-dependent order certainly can't hurt. Although given the shape of the diff it's hard to tell if it helps. I'll make my usual plea for splitting these big files.

@affeldt-aist
Copy link
Member Author

I also think that lebesgue_measure.v should be split, it not well named anyway, its first part is about real-valued measurable functions, I didn't go as far as appending its first part to measure.v because the latter is already very long, a new file like measurable_realfun.v might be better, what about recording the splitting idea as a issue for later (unless you think it is a better idea to do it now)?

@zstone1
Copy link
Contributor

zstone1 commented Sep 8, 2024

I think a measurable_realfun.v would be great. But it doesn't have to happen now. An issue is sufficient.

@affeldt-aist affeldt-aist merged commit f718317 into math-comp:master Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation 📝 This issue/PR is about documentation of the library / repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong documentation

2 participants