Unpointed topologies with no backwards compatibility#1312
Merged
zstone1 merged 5 commits intomath-comp:masterfrom Sep 13, 2024
Merged
Unpointed topologies with no backwards compatibility#1312zstone1 merged 5 commits intomath-comp:masterfrom
zstone1 merged 5 commits intomath-comp:masterfrom
Conversation
2 tasks
zstone1
changed the title
Contributor
Author
|
Note this has some catastrophic performance regression in 8.18. From my little debugging, it appears the Performance is unaffected on 8.19 and 8.20, though. So it probably makes sense to wait if we're planning on dropping 8.18 support soon anyway. |
CohenCyril
approved these changes
Sep 10, 2024
Member
CohenCyril
left a comment
CohenCyril
left a comment
There was a problem hiding this comment.
Let's drop 8.18 asap and merge.
This was referenced Sep 12, 2024
Merged
affeldt-aist
changed the title
affeldt-aist
added
the
renaming/refactoring 🔧
zstone1
force-pushed
the
unpointed-no-backcompact
branch
from
100f779 to
dc67866
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates the Pointed structure from TopologicalType. Definitely not backwards compatible, but most people shouldn't notice since once we hit pseudometric_zmodType we put Pointed back in there anyway. See #1191 for a previous attempt.
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers