Lemma -> Let in HB.builders#1295
Merged
affeldt-aist merged 2 commits intomath-comp:masterfrom Aug 20, 2024
Merged
Conversation
affeldt-aist
added
the
renaming/refactoring 🔧
zstone1
approved these changes
Aug 19, 2024
affeldt-aist
force-pushed
the
topology_20240818
branch
from
363dda6 to
a40abcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I think that lemmas proved inside
HB.builderssections ought not be visible from outisde,hence this PR.
Side question: should we try to get rid of the
_subproofprefixes in mixins?fixes #1296 (this is related to the above side question)
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers