Skip to content

to avoid a universe inconsistency with ring#1287

Merged
proux01 merged 1 commit intomath-comp:masterfrom
affeldt-aist:wochoice_20240808
Aug 8, 2024
Merged

to avoid a universe inconsistency with ring#1287
proux01 merged 1 commit intomath-comp:masterfrom
affeldt-aist:wochoice_20240808

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Aug 8, 2024

Motivation for this change

It is possible that MathComp-Analysis 1.3.0 is not compatible with the ring tactics
in the sense that From mathcomp Require Import ring. triggers a universe inconsistency.
(Just try to import ring after anything that requires wochoice.)
That is not the first time that wochoice.v causes such a bug (#1198 (comment)).
It happens that avoiding the in3W lemma provides a way to void the problem.
(Tested on the prob_lang branches that rely a lot of ring, field, and lra.)
Hence this PR that I think should be merged asap and provided in MathComp-Analysis 1.4.0 asap.

Checklist

- [ ] added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist affeldt-aist added the "bug" 🐛 This issue (resp. PR) describes (resp. fixes) a "bug" label Aug 8, 2024
@affeldt-aist affeldt-aist added this to the 1.4.0 milestone Aug 8, 2024
@proux01 proux01 merged commit cc30e18 into math-comp:master Aug 8, 2024
@affeldt-aist
Copy link
Member Author

As feared:

affeldt-aist/monae#141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

"bug" 🐛 This issue (resp. PR) describes (resp. fixes) a "bug"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants