splitting function space topologies#1166
Merged
affeldt-aist merged 8 commits intomath-comp:masterfrom Mar 14, 2024
Merged
Conversation
Closed
zstone1
commented
Jan 29, 2024
affeldt-aist
reviewed
Feb 9, 2024
affeldt-aist
reviewed
Feb 9, 2024
affeldt-aist
reviewed
Feb 9, 2024
Member
|
I made a first pass. A few things (doc) were not moved, a few removed things were not documented in the changelog, and I formatted a bit the documentation and suppressed a couple of parentheses here and there. I left a few comments mostly documentation that we'd better address now. Yet, a very welcome PR! |
affeldt-aist
reviewed
Feb 9, 2024
affeldt-aist
approved these changes
Mar 11, 2024
Member
|
As a last check I mostly checked the doc for typos. |
f982af8 to
81a3ce4
Compare
Member
|
I added two NBs and force-pushed to merge asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Three important changes here.
topology.vfile is huge, and kinda unpleasant for development. This splits all the function space topology stuff into a separate file. Note thatprod_topology(notU*V, butforall i : U, K iis a function space. So all that stuff, including tychonoff's theorem, lives infunction_spaces.v.->. It's a bit arbitrary to choose the topology of uniform convergence, and it was causing other bugs. Assigning topologies to aliases of->likecompact-openhad to be done in modules to avoid some HB errors. This cleans all that up. It also introducesArrowAsXmodules that can locally assign a canonical topology to->.pointwise_fun, which was a layer of indirection that I believe is no longer serving a purpose. It was an alias forprod_topology (fun (_:U) => V). But should have all the same canonicals. Seems better to just use the dedicated notation{ptws, U -> V}.A few other notes.
Filter Finto the context. Not a big deal, but a little surprising. All the instances areGlobal, so I can't tell why the inference would be different. I don't consider this blocking, as it's a very minor inconvenience.topology.v. Probably worth a quick scan to double check.Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers