Merged
Conversation
affeldt-aist
added
enhancement ✨
affeldt-aist
requested review from
CohenCyril
and removed request for
CohenCyril
proux01
approved these changes
Dec 4, 2023
Collaborator
proux01
left a comment
proux01
left a comment
There was a problem hiding this comment.
I only looked at the statement, they mostly look good modulo some bikesheding.
The proofs seem indeed quite long, I wonder whether the previous ones on nat could at least be derived from the new ones? (in a future PR of course)
Member
Author
|
TODO: lemmes giving equivalents defs {homo f : x y / x < y >-> x <= y} for nondecreasing or {homo f : x y / x < y >-> x < y} for increasing... @proux01 |
proux01
force-pushed
the
realfun_20231116
branch
from
7d32a04 to
458e1ec
Compare
Collaborator
|
Applied the few suggested changes, will merge once CI is green. |
Member
Author
Thank you! I couldn't do it today, but I have more of the same vein to come soon so I'll be able to look at the proofs again as I promised. |
affeldt-aist
removed
the
TODO: MC2 port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Lemmas about limits of real-valued/extended read-valued functions
needed to develop the theory of lim inf/sup (hence the emphasis on
at_rightversions).The theory of lim inf/sup is a forthcoming PR and is itself a prerequisite for the FTC.
The proofs for extended real-valued functions use the proofs for real-valued functions
but are still longish because of corner cases.
Things done/to do
CHANGELOG_UNRELEASED.mdCompatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.