Update meta-project-migrate to pass "branch" to splitSubtree()#119
Open
kaelansmith wants to merge 1 commit intomateodelnorte:masterfrom
Open
Update meta-project-migrate to pass "branch" to splitSubtree()#119kaelansmith wants to merge 1 commit intomateodelnorte:masterfrom
kaelansmith wants to merge 1 commit intomateodelnorte:masterfrom
Conversation
Author
|
I now see that this previous PR also addressed this issue and more: #95 -- perhaps it needs to be revisited, or we can at least just merge my simple fix to handle the specific issue of customizing branch name? I also just saw this past issue: mateodelnorte/meta#281 -- perhaps customizing the branch name via command-line argument doesn't fix all branch-related issues, and the concept of adding a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that splitSubtree() was set up to accept a "branch" parameter, with a default value set to "master"; and the meta-project-migrate script already seems to accept a final command-line argument for "branch" (which isn't documented btw), HOWEVER, the script doesn't actually pass the user-specified "branch" through to splitSubtree() -- so if your main branch isn't called "master" (like mine), the migrate script doesn't work. This PR adds a single-line fix, although untested.