Installation improvements. #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejsmycka
reviewed
Jan 7, 2026
matejsmycka
reviewed
Jan 7, 2026
install.sh
Outdated
| function make_executable() { | ||
| go build -o $executable | ||
| go build -o $executable \ | ||
| || podman run --rm -v "$PWD:/workdir:Z" -w "/workdir" golang:1 go build -o $executable \ |
Owner
There was a problem hiding this comment.
Suggested change
| || podman run --rm -v "$PWD:/workdir:Z" -w "/workdir" golang:1 go build -o $executable \ | |
| || podman run --rm -v "$PWD:/workdir" -w "/workdir" golang:1 go build -o $executable \ |
Contributor
Author
There was a problem hiding this comment.
I have not been able to test elsewhere, but on my machine selinux is enabled (fedora based), and without the context parameter (the Z) the container is not able to access the files that is mounted. To work around this I suppose I could setup a volume, copy the files into that volume, build, then copy the binary back out of the volume after, but it seems easier to just mount the path.
Owner
|
Thank you for the contribution! I have some nitpicks, otherwise, LGTM. |
Owner
|
Additionally, please update the README.md file in the requirements section. |
Owner
|
Thank you for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to the installation script to expand the possibilities of installation working well for more users.