Skip to content

RDA: Don't apply stored monitor configuration if session is remote.#306

Open
sunweaver wants to merge 1 commit intomate-desktop:masterfrom
sunweaver:pr/rda
Open

RDA: Don't apply stored monitor configuration if session is remote.#306
sunweaver wants to merge 1 commit intomate-desktop:masterfrom
sunweaver:pr/rda

Conversation

@sunweaver
Copy link
Member

With remote sessions (like X2Go, xRDP, etc.) the xRandR configuration is normally handled by the remote desktop technology in use.

This change adds a return early to MATE's xrandr MSD monitor resolution restoring code path, if the session is remote.

Note: this PR requires a new build dependency on librda [1]

[1] https://github.com/ArcticaProject/librda.git

gboolean result;

#ifdef HAVE_RDA
if (rda_session_is_remote()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respect code style. File doesn't use tabs.

@lukefromdc
Copy link
Member

Any updates on this or should we close it? Tabs need to go, and conflict needs to be fixed to continue with it

@lukefromdc
Copy link
Member

This is actually worth finishing, so as to avoid risk of invalidating someone's local monitor setup during a remote connection

@joakim-tjernlund
Copy link

This is actually worth finishing, so as to avoid risk of invalidating someone's local monitor setup during a remote connection

Yes, please. If the only concern is white SPACE fixes, just re-indent and merge ?

@lukefromdc
Copy link
Member

Note that since this is on someone else's repo, I cannot fix the tab issue or manually apply the changes to conflicting files on this PR. Instead I have to copy it and submit it as a new PR and close this one. We havn't heard from anyone else on the team about this in over four years, nobody has reviewed it functionally, and I never use remote sessions myself and have never been able to test them.

I don't think merging untested changes is a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants