Skip to content

add solution#4281

Open
MartaKurdylo wants to merge 1 commit intomate-academy:masterfrom
MartaKurdylo:master
Open

add solution#4281
MartaKurdylo wants to merge 1 commit intomate-academy:masterfrom
MartaKurdylo:master

Conversation

@MartaKurdylo
Copy link

  • Install Prettier Extention and use this VSCode settings to enable format on save.
  • Implement a solution following the React task guideline
  • Open one more terminal and run tests with npm test to ensure your solutions is correct
  • Replace <your_account> with your Github username in the DEMO LINK and add it to the PR description

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution because all core functional requirements are implemented correctly: the app is decomposed into Welcome, Navigation, Header, and Article components, each component has its own CSS file, and all components use export default as required. The JSX and CSS across the files are valid, clearly structured, and there are no visible runtime or syntax issues that would block functionality.

There are a few non-blocking points to keep in mind: you currently have navigation markup both inside Header.jsx and in the separate Navigation.jsx, which can lead to duplicated navigation in the UI, so it’s better to keep the <nav> only in the Navigation component and let Header focus on the title. Also, the task asks you to: (1) run npm test and confirm that tests pass, (2) ensure Prettier/VSCode format-on-save settings are configured, and (3) update the PR description with the correct DEMO LINK (https://YourGitHubUsername.github.io/react_decompose/), so make sure you do those in your PR even though they are not code blockers. Overall, your decomposition and per-component styling are solid, and you’re very close to a fully polished submission; just address these small polish items for future tasks.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants