Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job setting up the tests for isIsogram! You've done well to cover edge cases like the empty string and case-insensitivity. However, a couple of changes are needed before this can be approved. Your test suite is currently missing a key scenario: a test for a valid isogram that should return true, such as 'playgrounds'. Additionally, one of your test descriptions in src/isIsogram.test.js is misleading. The test described as should return true if there's no repeating letters actually asserts false for words with repeating letters. Please update the description to accurately reflect what the test does, for example: should return false if there are repeating letters. Adding this missing test and correcting the description will make your test suite complete and robust!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job adding the test case for valid isograms! We're very close to getting this approved. The only remaining issue is a misleading test description in src/isIsogram.test.js. The description should return false if there's no repeating letters is incorrect, as the test actually checks words that do have repeating letters (like 'look') and asserts that the function returns false. Please update the description to accurately reflect the test's purpose, for example: should return false for words with repeating letters. Once that's fixed, this will be ready to go!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/isIsogram.test.js
Outdated
| .toBe(true); | ||
| }); | ||
|
|
||
| it(`should return false if there's no repeating letters`, () => { |
There was a problem hiding this comment.
This test description is still a bit misleading. A word with 'no repeating letters' is an isogram and should return true. This test correctly checks words that do have repeating letters (like 'look') and expects false.
A clearer description would be something like: should return false for words with repeating letters.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this task! You've successfully addressed the feedback from the previous review by correcting the test description. Your test suite is now comprehensive, covering all requirements and edge cases with clear and accurate descriptions. This is a great submission, and I'm happy to approve it. Keep up the fantastic work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.