Skip to content

Added solution#449

Open
YevheniiKa wants to merge 1 commit intomate-academy:masterfrom
YevheniiKa:develop
Open

Added solution#449
YevheniiKa wants to merge 1 commit intomate-academy:masterfrom
YevheniiKa:develop

Conversation

@YevheniiKa
Copy link

Added solution

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! Your server correctly meets all the functional requirements, including parsing the pathname and query parameters, and handling double slashes. I am approving your solution.

As a suggestion for future improvement, I noticed you're using the url.parse() method in src/createServer.js. While it works here, this is a legacy API that is now deprecated. For new projects, it's better to use the modern WHATWG URL API. Here's how you could achieve the same result:

const requestUrl = new URL(req.url, `http://${req.headers.host}`);
const pathname = requestUrl.pathname;
const query = Object.fromEntries(requestUrl.searchParams);

This is just a recommendation for best practice and doesn't block this submission. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants