solution by Anton-Kuchmasov · Pull Request #167 · mate-academy/node_form-data

Anton-Kuchmasov · 2025-10-26T20:34:05Z

No description provided.

mateacademy-ai-mentor

Review Summary

Great job setting up the Node.js server and handling the form data submission correctly! Your code successfully saves the expenses to the JSON file. However, a few changes are needed to meet all requirements. The main issue is that the server responds to the POST request with raw JSON instead of an HTML page. The task requires returning an HTML page that displays the saved data. To fix this, please set the Content-Type header to text/html and wrap the JSON string in basic HTML tags, like <html><body><pre>...</pre></body></html>. Also, for client-side errors like missing form fields, please use the 400 Bad Request status code, as 500 Internal Server Error is meant for server-side failures. After these adjustments, your solution will be complete!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2025-10-26T20:35:24Z

src/createServer.js

+const BASE_PUBLIC_DIR = path.resolve('public');
+
+function sendBadRequest(res) {
+  res.statusCode = 500;


The HTTP status code 500 is generally used for "Internal Server Error". For client-side errors like a malformed request or missing data, the 400 Bad Request status code is more appropriate and conventional.

mateacademy-ai-mentor · 2025-10-26T20:35:24Z

src/createServer.js

+    }
+
+    if (req.method === 'POST' && req.url === '/add-expense') {
+      res.setHeader('Content-type', 'application/json');


The task requires returning an HTML page, but the Content-Type is set to application/json. This header should be text/html to indicate that the response body is an HTML document.

mateacademy-ai-mentor · 2025-10-26T20:35:24Z

src/createServer.js

+
+        writeStream.write(JSON.stringify(preparedData), () => {
+          writeStream.end();
+          res.end(JSON.stringify(preparedData));


According to the requirements, the server should return an HTML page that contains the well-formatted JSON. This line sends only the raw JSON string as the response. You should wrap the stringified JSON data in HTML tags, for example, <html><body><pre>${JSON.stringify(preparedData, null, 2)}</pre></body></html>.

mateacademy-ai-mentor

Review Summary

I am requesting changes because a core requirement and a test are currently failing. In src/createServer.js, the POST /add-expense response sets Content-Type: text/html but sends raw JSON; the spec requires returning an HTML page that displays the saved data as pretty-printed JSON, and the test expects a consistent, correct header. Please wrap the JSON in minimal HTML (e.g., <html><body><pre>{pretty JSON}</pre></body></html>) and set the header appropriately before res.end (e.g., text/html). Additionally, guard the header check to avoid runtime errors: use const ct = req.headers['content-type'] || '' before ct.includes('application/json'). Finally, handle file write errors: either switch to fs.writeFile(..., cb) and send a 500 on error or attach an 'error' listener to the write stream and respond safely. Minor: standardize header casing to Content-Type. Good job on routing, validation, and static serving—once these blockers are addressed, you should be all set.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2025-10-27T14:37:16Z

src/createServer.js

+      res.setHeader('Content-type', 'application/json');
+
+      const chunks = [];
+      let rawData = '';
+
+      req.on('data', (chunk) => {
+        chunks.push(chunk);
+      });
+
+      req.on('end', () => {
+        rawData = Buffer.concat(chunks).toString();
+
+        let preparedData = '';
+
+        // extra logic: in tests cases requests are in application/json,
+        // but IRL, formdata usually comes as application/x-form-encoded
+        // hope that MA guys will re-write this task (as well as previous one)
+        if (req.headers['content-type'].includes('application/json')) {
+          preparedData = JSON.parse(rawData);
+        } else {
+          preparedData = handleRawFormData(rawData, res);
+        }
+
+        if (!preparedData.date || !preparedData.title || !preparedData.amount) {
+          sendBadRequest(res);
+
+          return;
+        }
+
+        const writeStream = fs.createWriteStream(
+          path.resolve('db/expense.json'),
+        );
+
+        writeStream.write(JSON.stringify(preparedData), () => {
+          writeStream.end();
+          res.end(JSON.stringify(preparedData));


You set the response header to HTML, but here the code sends raw JSON. The task requires returning an HTML page showing the saved data. Wrap the pretty-printed JSON in basic HTML (for example using a <pre> block) before calling res.end so the browser shows formatted JSON.

mateacademy-ai-mentor · 2025-10-27T14:37:16Z

src/createServer.js

+        // extra logic: in tests cases requests are in application/json,
+        // but IRL, formdata usually comes as application/x-form-encoded
+        // hope that MA guys will re-write this task (as well as previous one)
+        if (req.headers['content-type'].includes('application/json')) {


This line calls .includes() on req.headers['content-type'] which will throw if the header is missing. Guard the header first, e.g. const ct = req.headers['content-type'] || '' and then check ct.includes('application/json').

mateacademy-ai-mentor · 2025-10-27T14:37:17Z

src/createServer.js

+        const writeStream = fs.createWriteStream(
+          path.resolve('db/expense.json'),
+        );
+
+        writeStream.write(JSON.stringify(preparedData), () => {
+          writeStream.end();
+          res.end(JSON.stringify(preparedData));
+        });


You create and write to a write stream but do not handle write errors. If the filesystem write fails the response may hang or the server may crash. Consider using fs.writeFile with a callback (and respond 500 on error) or listen for the writeStream 'error' event and handle it before ending the response.

mateacademy-ai-mentor

Review Summary

I am approving this submission as an educational override to help you progress, but there are a few key requirements from the previous review that still need your attention.

Great job adding the check for the content-type header to make the server more robust! However, the server must respond to the POST request with an HTML page, not raw JSON. Please remember to set the Content-Type header to text/html and wrap the saved data in a basic HTML structure, for example: <html><body><pre>YOUR_JSON_DATA</pre></body></html>.

Additionally, it's crucial to add error handling for the fs.writeFile operation. The callback function provides an error object as its first argument, which you should check to handle cases where the file can't be written.

You're very close to finishing this task. Keep up the great work!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor · 2025-10-27T14:52:41Z

src/createServer.js

+    }
+
+    if (req.method === 'POST' && req.url === '/add-expense') {
+      res.setHeader('Content-type', 'application/json');


According to the task requirements, the server should respond with an HTML page. Therefore, the Content-Type header for this response should be set to text/html.

mateacademy-ai-mentor · 2025-10-27T14:52:41Z

src/createServer.js

+          () => {
+            res.end(JSON.stringify(preparedData));
+          },


The callback for fs.writeFile receives an error object as its first argument. It's crucial to handle this case. If an error occurs during file writing, the server should send back an appropriate error response (e.g., status code 500).

mateacademy-ai-mentor · 2025-10-27T14:52:42Z

src/createServer.js

+          path.resolve('db/expense.json'),
+          JSON.stringify(preparedData),
+          () => {
+            res.end(JSON.stringify(preparedData));


The task requires returning an HTML page that displays the saved data, but the current implementation sends a raw JSON string. The JSON data should be embedded within an HTML structure, for example: <html><body><pre>${JSON.stringify(preparedData, null, 2)}</pre></body></html>.

solution

16af0d3

mateacademy-ai-mentor suggested changes Oct 26, 2025

View reviewed changes

solution

9bb0069

Anton-Kuchmasov requested a review from mateacademy-ai-mentor October 27, 2025 14:30

solution

24def00

mateacademy-ai-mentor suggested changes Oct 27, 2025

View reviewed changes

final fixes

6e2b306

Anton-Kuchmasov requested a review from mateacademy-ai-mentor October 27, 2025 14:51

mateacademy-ai-mentor approved these changes Oct 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

solution#167

solution#167
Anton-Kuchmasov wants to merge 4 commits intomate-academy:masterfrom
Anton-Kuchmasov:develop

Anton-Kuchmasov commented Oct 26, 2025

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor Oct 26, 2025

Uh oh!

mateacademy-ai-mentor Oct 26, 2025

Uh oh!

mateacademy-ai-mentor Oct 26, 2025

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor Oct 27, 2025

Uh oh!

mateacademy-ai-mentor Oct 27, 2025

Uh oh!

mateacademy-ai-mentor Oct 27, 2025

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor Oct 27, 2025

Uh oh!

mateacademy-ai-mentor Oct 27, 2025

Uh oh!

mateacademy-ai-mentor Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Anton-Kuchmasov commented Oct 26, 2025

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants