Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on this submission! The core functionality is implemented correctly, and the test suite is particularly impressive for its thoroughness.
However, I'm requesting a small change to align the error handling with the project requirements. In src/app.js, one of the error paths throws an exception, which causes the application to crash. The requirements specify that errors should be logged using console.error().
Please update the try...catch block to use console.error(err) instead of throw err;. This will make the error handling consistent throughout the file and prevent the application from crashing unexpectedly.
Once that's fixed, this will be ready to go!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/app.js
Outdated
| } | ||
| } catch (err) { | ||
| if (err.code !== 'ENOENT') { | ||
| throw err; |
There was a problem hiding this comment.
According to the task requirements, errors should be reported using console.error(). Throwing the error here causes the application to crash, which is inconsistent with how other errors are handled in this function (e.g., lines 38 and 47). Consider logging the error with console.error() instead.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on addressing the previous feedback and building out the test suite! The error handling is much more robust now.
However, there's one small but important change needed in src/app.js. In the try...catch block that checks the destination path, if an error other than ENOENT occurs (like a permissions issue), the error is logged, but the function doesn't exit. This causes the application to proceed and crash when it tries to call copy(from, to).
To fix this and make the behavior consistent with your other error checks, please add a return; statement after console.error(err); in that block. This will ensure the application exits gracefully in all error scenarios.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| } | ||
| } catch (err) { | ||
| if (err.code !== 'ENOENT') { | ||
| console.error(err); |
There was a problem hiding this comment.
Nice catch handling non-ENOENT errors here. However, after logging the error, the function proceeds to call copy(from, to). This will likely cause the application to crash if fs.statSync failed due to an issue like permissions. To keep the behavior consistent with other error checks in this function, consider adding a return statement after logging the error.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! You've successfully addressed the feedback from the previous review by adding the return statement to the final try...catch block. Your application now handles all error cases correctly and meets all the requirements of the task. The code is well-structured and robust, and I am happy to approve your solution.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.