Conversation
Patryk-Buczkowski
commented
May 24, 2023
- DEMO LINK
- TEST REPORT LINK
Radoslaw-Czerniawski
left a comment
There was a problem hiding this comment.
Left one comment on the code structure, will look into css after you deploy the demo.
| <link rel="stylesheet" href="./style.css"> | ||
| </head> | ||
| <body> | ||
| <div class="container"> |
There was a problem hiding this comment.
Generally you should have an empty line only between siblings of a parent not parent and child,
<div>
<span>first child</span>
<span>first child</span>
</div>also like here when you have exact same elements next to each other then don't do any empty lines between them, like in this example:
<ul>
<li>text</li>
<li>text</li>
<li>text</li>
<li>text</li>
</ul>
Radoslaw-Czerniawski
left a comment
There was a problem hiding this comment.
Almost done, move the styling higher
| margin: 0; | ||
| } | ||
|
|
||
| .container { |
There was a problem hiding this comment.
Generally you are doing a mobile first approach here, where you first style for screen smaller than 600px, that's good however when doing so logically these style for screen smaller than 600px should be declared before @media (min-width:600px), move these lines beginning at line 53 after * { box-sizing: border-box; }