Conversation
Luk2asz
commented
May 20, 2023
Luk2asz
commented
- DEMO LINK
- TEST REPORT LINK
DorotaLeniecDev
left a comment
DorotaLeniecDev
left a comment
There was a problem hiding this comment.
Fix formating and use class for styling
src/index.html
Outdated
| <input type="text" | ||
| name="surname" autocomplete="off" | ||
| > |
There was a problem hiding this comment.
Fix formating in this file. Check the checklist for guidelince. It should be formatet like this:
| <input type="text" | |
| name="surname" autocomplete="off" | |
| > | |
| <input | |
| type="text" | |
| name="surname" | |
| autocomplete="off" | |
| > |
There was a problem hiding this comment.
I have corrected my code, please check now
src/index.html
Outdated
| <fieldset> | ||
| <legend>Personal information</legend> | ||
| <div class="form"> | ||
| <label> |
There was a problem hiding this comment.
Dont wrapp inputs with label.
| <label> | |
| <label for="surname">Surname:</label> |
Add appropriate ids to form elements do the labels is connected
There was a problem hiding this comment.
I have corrected my code, please check now
src/index.html
Outdated
| <form action="https://mate-academy-form-lesson.herokuapp.com/create-application" method="post"> | ||
| <fieldset> | ||
| <legend>Personal information</legend> | ||
| <div class="form"> |
There was a problem hiding this comment.
Change class name so it is not missleading. This HTML does not represents form, it is more like field-wrapper
There was a problem hiding this comment.
I have corrected my code, please check now
src/style.css
Outdated
| margin-bottom: 10px; | ||
| } | ||
|
|
||
| fieldset { |
There was a problem hiding this comment.
Dont style using tags, add propper class name and style using it
There was a problem hiding this comment.
I have corrected my code, please check now
darokrk
left a comment
darokrk
left a comment
There was a problem hiding this comment.
Looks nice 👍🏽 give approval, but I have added two suggestions for improvement which take a look at :)
| id="no" | ||
| > | ||
|
|
||
| <label for="no">Yes</label> |
There was a problem hiding this comment.
The label text for the 'no' radio button should be 'No' instead of 'Yes'
| margin-bottom: 10px; | ||
| } | ||
|
|
||
| .chapter-wrapper { |
There was a problem hiding this comment.
I would suggest here to give a more descriptive name for this class, maybe something like .fieldset-wrapper or .form-section :)
3 participants
