added task solution by LabPetro · Pull Request #790 · mate-academy/layout_html-form

LabPetro · 2023-05-17T00:53:34Z

Anastasiia-Svintsova · 2023-05-17T10:40:41Z

src/style.css

@@ -1 +1,12 @@
-/* styles go here */
+.duo {


Use a more descriptive class name instead of 'duo'. For example, 'form-group'.

Anastasiia-Svintsova · 2023-05-17T10:40:41Z

src/style.css

+  margin-bottom: 20px;
+}
+
+.quads {


Use a more descriptive class name instead of 'quads'. For example, 'form-block'.

Anastasiia-Svintsova · 2023-05-17T10:41:22Z

src/index.html

+           id="review"
+           name="rating"
+           step="1"
+           max="0"


The max attribute of the 'review' input should be greater than the min attribute. It doesn't work

Anastasiia-Svintsova · 2023-05-17T10:41:22Z

src/index.html

+      class="duo"
+      type="text"
+      id="surname"
+      name="info"


The name attribute should be more descriptive, e.g. 'surname' instead of 'info'.

Anastasiia-Svintsova · 2023-05-17T10:41:22Z

src/index.html

+      class="duo"
+      type="text"
+      id="name"
+      name="information"


The name attribute should be more descriptive, e.g. 'name' instead of 'information'.

Anastasiia-Svintsova · 2023-05-17T10:48:08Z

src/index.html

+        <input
+      class="duo"
+      type="text"
+      id="surname"
+      name="info"
+      autocomplete="off"


Check the code style everywhere

Suggested change

<input

class="duo"

type="text"

id="surname"

name="info"

autocomplete="off"

<input

class="duo"

type="text"

id="surname"

name="info"

autocomplete="off"

Anastasiia-Svintsova · 2023-05-17T10:49:07Z

src/index.html

+
+        <div class="duo">
+          <label for="cat">Do you love cats?</label>
+          <input


Add a label to each radio button. It doesn't work correctly now

Screen.Recording.2023-05-17.at.13.49.21.mov

Anastasiia-Svintsova · 2023-05-17T10:50:50Z

src/index.html

+        </div>
+
+      </fieldset>


Suggested change

</div>

</fieldset>

</div>

</fieldset>

Anastasiia-Svintsova · 2023-05-17T10:52:06Z

src/index.html

+      <button
+       type="submit"
+      >


Suggested change

<button

type="submit"

>

<button type="submit">

Anastasiia-Svintsova · 2023-05-17T10:52:34Z

src/style.css

+  margin-bottom: 10px;
+}
+
+fieldset {


Use classes for styling

agniya-i · 2023-05-18T17:33:58Z

src/index.html

+          <label for="yes">Yes</label>
+          <input
+            id="yes"
+            type="radio"
+            name="pet"
+            value="yes"
+          >
+          <label for="no">No</label>
+          <input
+            id="no"
+            type="radio"
+            name="pet"
+            value="No"
+          >


Suggested change

<label for="yes">Yes</label>

<input

id="yes"

type="radio"

name="pet"

value="yes"

>

<label for="no">No</label>

<input

id="no"

type="radio"

name="pet"

value="No"

>

<label>

<input

id="yes"

type="radio"

name="pet"

value="yes"

>

Yes

</label>

<label>

<input

id="no"

type="radio"

name="pet"

value="No"

>

No

</label>

You can wrap it into label tag to fix previous comment

agniya-i · 2023-05-18T17:34:22Z

src/index.html

+          <input type="range"
+            id="review"
+            name="rating"
+            step="1"
+            value="0"
+            min="0"
+            max="5"
+          >


Suggested change

<input type="range"

id="review"

name="rating"

step="1"

value="0"

min="0"

max="5"

>

<input

type="range"

id="review"

name="rating"

step="1"

value="0"

min="0"

max="5"

>

agniya-i · 2023-05-18T17:34:47Z

src/index.html

+          <textarea name="write"
+            id="comments"
+            autocomplete="off"
+            required
+         ></textarea>


Suggested change

<textarea name="write"

id="comments"

autocomplete="off"

required

></textarea>

<textarea

name="write"

id="comments"

autocomplete="off"

required

></textarea>

agniya-i · 2023-05-18T17:35:27Z

src/index.html

+          <option value="answer">Yes</option>
+          <option value="answer">No</option>


Suggested change

<option value="answer">Yes</option>

<option value="answer">No</option>

<option value="yes">Yes</option>

<option value="no">No</option>

Anastasiia-Svintsova · 2023-05-19T10:48:06Z

src/index.html

+    <form
+     action="https://mate-academy-form-lesson.herokuapp.com/create-application"
+     method="post">


Suggested change

<form

action="https://mate-academy-form-lesson.herokuapp.com/create-application"

method="post">

<form

action="https://mate-academy-form-lesson.herokuapp.com/create-application"

method="post"

>

Anastasiia-Svintsova · 2023-05-19T10:48:25Z

src/index.html

+
+      <fieldset class="container">


Don't add spaces between parent and child components

added task solution

64cc0d5

Anastasiia-Svintsova suggested changes May 17, 2023

View reviewed changes

Updated suggested changes

d502691

LabPetro requested a review from Anastasiia-Svintsova May 18, 2023 12:44

agniya-i suggested changes May 18, 2023

View reviewed changes

Update No 2

ef65d71

LabPetro requested a review from agniya-i May 18, 2023 22:55

Anastasiia-Svintsova approved these changes May 19, 2023

View reviewed changes

		<option value="answer">Yes</option>
		<option value="answer">No</option>

Conversation

LabPetro commented May 17, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants