Develop

[Patryk-Buczkowski]

• DEMO LINK
• TEST REPORT LINK

[Radoslaw-Czerniawski]

Adjust according to my comments and the checklist

[Radoslaw-Czerniawski]

There shouldn't be empty line between parent and first child

[Radoslaw-Czerniawski]

You should have empty lines only between siblings on the same level, not between parent and child, here's an example

<section>
  <div>
    <span>First Child of Div</span>

    <span>Second Child of Div</span>
  <div>
</section>

[Radoslaw-Czerniawski]

An exemption to that rule would be an ul

<ul>
  <li></li>
  <li></li>
  <li></li>
  <li></li>
</ul>

[Radoslaw-Czerniawski]

In the rest of your markup doesn't adhere to these rules so adjust accordingly, also take a look at the checklist and also adhere to it's rules

[Radoslaw-Czerniawski]

This script should be at the bottom of the markup to work move it below your form

[Radoslaw-Czerniawski]

Remove those 2 empty lines

[DorotaLeniecDev]

Few minor changes needed :)

[DorotaLeniecDev]

Remove
tags, you can achive this by grouping form-fiels into block element like this:

Suggested change

	<label for="surname">Surname:</label>
	<input
	id="surname"
	type="text"
	name="surname"
	autocomplete="off"
	class="input"
	>
	<br>
	<div class="form-field">
	<label for="name">Name:</label>
	<input
	type="text"
	name="name"
	id="name"
	autocomplete="off"
	required
	>
	</div>

When you wrap label and input into div, it will take 100% width and make newline automatically for next elements. Wrapp all fields like this and remove
:)

[DorotaLeniecDev]

And you can easly style it like this:

Suggested change

	.input {
	margin-bottom: 10px;
	display: inline-block;
	}
	.form-field {
	margin-bottom: 10px;
	}

[DorotaLeniecDev]

Close label tag here:

Suggested change

	<label for="car" class="input">
	What are your favorite brand of cars?
	<label for="car" class="input">
	What are your favorite brand of cars?
	</label>

[DorotaLeniecDev]

Fix formating:

Suggested change

	<select
	id="car"
	name="carBrand"
	multiple
	>
	<select
	id="car"
	name="carBrand"
	multiple
	>

[DorotaLeniecDev]

Suggested change

	<label for="comments" class="input">
	Comments:
	<label for="comments" class="input">
	Comments:
	</label>

[DorotaLeniecDev]

Add empty line between siblings

Suggested change

	<label for="recommend" >Would you recommend us?</label>
	<select
	id="recommend"
	name="recommend"
	>
	<label for="recommend" >Would you recommend us?</label>
	<select
	id="recommend"
	name="recommend"
	>

[DorotaLeniecDev]

Suggested change

	</fieldset>
	<button type="submit">Submit</button>
	</fieldset>
	<button type="submit">Submit</button>

[darokrk]

Looks nice 🥇 ! I give approve but please correct the indentation in the code according to the example given :)

[darokrk]

Like Radek mentioned before there should not be an empty line.

"You should have empty lines only between siblings on the same level, not between parent and child, here's an example"

<section>
  <div>
    <span>First Child of Div</span>

    <span>Second Child of Div</span>
  <div>
</section>

[Patryk-Buczkowski]

It's done ;)