Open
Conversation
Anastasiia-Svintsova
suggested changes
Apr 27, 2023
Anastasiia-Svintsova
left a comment
Anastasiia-Svintsova
left a comment
There was a problem hiding this comment.
- The user should be able to choose only one option (yes or no). Fix these radio buttons, pelase
Screen.Recording.2023-04-27.at.12.36.45.mov
Comment on lines
+3
to
+4
| - [DEMO LINK](https://kyrylomanko.github.io/layout_html-form/) | ||
| - [TEST REPORT LINK](https://kyrylomanko.github.io/layout_html-form/report/html_report/) |
There was a problem hiding this comment.
You should add these links to the PR description
src/index.html
Outdated
| id="surname" | ||
| name="surname" | ||
| autocomplete="off" | ||
| ><br> |
There was a problem hiding this comment.
Why do you need these br tags everywhere? Remove them
Suggested change
| ><br> | |
| > |
src/index.html
Outdated
| <label for="surname">Surname:</label> | ||
| <input | ||
| cletype="text" | ||
| class="distance" |
There was a problem hiding this comment.
Use more meaningful class names. For example:
Suggested change
| class="distance" | |
| class="form-field" |
src/index.html
Outdated
Comment on lines
59
to
61
| > | ||
|
|
||
| </fieldset> |
There was a problem hiding this comment.
Suggested change
| > | |
| </fieldset> | |
| > | |
| </fieldset> |
src/index.html
Outdated
Comment on lines
79
to
81
| > | ||
|
|
||
| </fieldset> |
There was a problem hiding this comment.
Don't add spaces between parent and child elements
Suggested change
| > | |
| </fieldset> | |
| > | |
| </fieldset> |
src/style.css
Outdated
| margin-bottom: 10px; | ||
| } | ||
|
|
||
| fieldset { |
There was a problem hiding this comment.
Don't style tags, use class selector instead
witflash
suggested changes
Apr 27, 2023
witflash
left a comment
witflash
left a comment
There was a problem hiding this comment.
Almost done but just one thing:
Could you check if you use these attributes at least one time?
qoa11a
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK