add code, styles and script to create landing#720
Open
entodasha wants to merge 4 commits intomate-academy:masterfrom
Open
add code, styles and script to create landing#720entodasha wants to merge 4 commits intomate-academy:masterfrom
entodasha wants to merge 4 commits intomate-academy:masterfrom
Conversation
Anton-Kuchmasov
suggested changes
Oct 10, 2025
Anton-Kuchmasov
left a comment
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Great job you did!
To improve:
- Would you mind move that block into
<aside></aside>(it'd better symantically) and add some smooth transition here?
Author
|
@Anton-Kuchmasov, Yes, I think about that. But the menu is only used for phones and tablets, and for desktop navigation in the top bar. I can implement it as an aside for tablets and phones, and add extra navigation to the top bar header and show it only on desktop. Or is it the wrong way to add navigation to the top bar block? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK