Skip to content

add task solution#1751

Open
nols212 wants to merge 1 commit intomate-academy:masterfrom
nols212:develop
Open

add task solution#1751
nols212 wants to merge 1 commit intomate-academy:masterfrom
nols212:develop

Conversation

@nols212
Copy link

@nols212 nols212 commented Feb 17, 2026

  1. Replace <your_account> with your Github username in the link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution because it correctly fulfills the core functional requirements. Your main.js script iterates over the people array, creates a table row per person, and generates six cells containing name, gender/sex, born, died, computed age (died - born), and computed century (Math.ceil(died / 100)), then appends them to the .dashboard table as required. This means the main data transformation and DOM manipulation logic is in place and working as specified.

One minor improvement you could make is to remove the leftover console.log(people) and any eslint-disable comments once you finish debugging, so your code stays clean and linting can help you catch issues automatically. Also, make sure you’ve run the recommended test commands locally (like npm run test) and verified they pass, even if they weren’t shown in the PR. Overall, the implementation is clear, straightforward, and matches the task description—nice work completing the requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants