Skip to content

add task solution #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naviailpach wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #1815

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5ff27c
add task solution
naviailpach Feb 16, 2026
9340f9d
complete task
naviailpach Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,30 @@
'use strict';

// write code here
const inputs = document.querySelectorAll('form input');

inputs.forEach((input) => {
if (!input.name) {
return;
}

if (!input.id) {
input.id = `${input.name}-input`;
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You assign input.id = ${input.name}-input`` before checking the input type. Because you return for submit, `button`, and `hidden` inputs later (lines 14–18), those inputs may receive an id even though no label/placeholder is created. Consider moving the type check (lines 14–18) above the id assignment or only setting `id` after confirming the input will be processed.

}

if (
input.type === 'submit' ||
input.type === 'button' ||
input.type === 'hidden'
) {
return;
}

const label = document.createElement('label');
const labelText = input.name.charAt(0).toUpperCase() + input.name.slice(1);

label.classList.add('field-label');
label.htmlFor = input.id;
label.textContent = labelText;
input.placeholder = labelText;
input.parentNode.insertBefore(label, input);
});
Loading