Skip to content

add task solution#1806

Open
ATkachenkoA wants to merge 2 commits intomate-academy:masterfrom
ATkachenkoA:develop
Open

add task solution#1806
ATkachenkoA wants to merge 2 commits intomate-academy:masterfrom
ATkachenkoA:develop

Conversation

@ATkachenkoA
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

You've done a great job creating the label elements and correctly setting their attributes and text content. The logic for the placeholders is also spot on!

However, this requires one crucial change before it can be approved. The newly created <label> elements are never actually added to the document, so they don't appear on the page. The main requirement is to make the labels visible.

To fix this, you need to append each label to the parent element of the input it belongs to. You can get the parent with input.parentElement and then use a method like append() to add the label inside your loop.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment on lines 5 to 15
inputs.forEach((input) => {
const label = document.createElement('label');

label.classList.add('field-label');
label.setAttribute('for', input.id);
label.textContent = input.name;

const placeholder = input.name.charAt(0).toUpperCase() + input.name.slice(1);

input.placeholder = placeholder;
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The created label is correctly configured, but it's never added to the document. The requirements state that you should append the label to the parent container of the input element.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this iteration! You've successfully addressed the feedback from the previous review by appending the label elements to the DOM. The script is now fully functional, correctly creating and displaying both the labels and placeholders for the form fields. Your solution is clean, correct, and meets all the requirements of the task. I am approving your submission. Keep up the great effort!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants