Skip to content

Solution#813

Open
DagmaraProkop wants to merge 2 commits intomate-academy:mainfrom
DagmaraProkop:Develop
Open

Solution#813
DagmaraProkop wants to merge 2 commits intomate-academy:mainfrom
DagmaraProkop:Develop

Conversation

@DagmaraProkop
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 The code meets all the task requirements and constraints, and the test cases are well-structured. The only minor suggestion is regarding the ESLint configuration: if disabling the 'no-proto' rule was not intentional, you might want to set it to 'warn' or 'error' to avoid using the deprecated __proto__ property. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

'no-proto': 0,
strict: 0,
'max-len': 0,
'no-proto': 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'no-proto' rule is set to 0, which disables it. If this is not intentional, consider setting it to 'warn' or 'error' to enforce the rule and prevent the use of the deprecated 'proto' property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants